8279068: IGV: Update to work with JDK 16 and 17

[fitzsim]

I propose the following backport to jdk17u-dev:

8279068: IGV: Update to work with JDK 16 and 17

Reviewed-by: kvn, neliasso, chagedorn
Backport-of: 7bcca7692b62a37f70c757694f6acff0295371cc

This is a mostly-clean backport to 17. I had to move and apply manually these two lines:

--- src/utils/IdealGraphVisualizer/pom.xml
+++ src/utils/IdealGraphVisualizer/pom.xml
@@ -110,11 +131,12 @@
         <module>View</module>
     </modules>
     <properties>
-        <netbeans.version>RELEASE123</netbeans.version>
+        <netbeans.version>RELEASE126</netbeans.version>
         <swinglayouts.version>1.0.2</swinglayouts.version>
         <nbmmvnplugin.version>4.6</nbmmvnplugin.version>
         <mvncompilerplugin.version>3.8.1</mvncompilerplugin.version>
         <mvnjarplugin.version>3.2.0</mvnjarplugin.version>
+        <mvnenforcerplugin.version>3.0.0</mvnenforcerplugin.version>
         <junit.version>4.13.2</junit.version>
         <batik.version>1.14</batik.version>
         <openpdf.version>1.3.26</openpdf.version>

With this backport mvn install; sh igv.sh works fine for me on x86-64 Fedora 38, fastdebug build, without needing to add JVM options to the idealgraphviewer wrapper script, which I needed to do when testing #2487.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8279068 needs maintainer approval

Issue

• JDK-8279068: IGV: Update to work with JDK 16 and 17 (Enhancement - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2488/head:pull/2488
$ git checkout pull/2488

Update a local copy of the PR:
$ git checkout pull/2488
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2488

View PR using the GUI difftool:
$ git pr show -t 2488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2488.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fitzsim This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279068: IGV: Update to work with JDK 16 and 17

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
• ab84520: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
• d1e909f: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
• d608778: 8326106: Write and clear stack trace table outside of safepoint
• bcdb727: 8329004: Update Libpng to 1.6.43
• 08b3f72: 8312229: Crash involving yield, switch and anonymous classes
• a0c72d0: 8320692: Null icon returned for .exe without custom icon
• 352d258: 8328953: JEditorPane.read throws ChangedCharSetException
• 4d5ed55: 8332898: failure_handler: log directory of commands
• a9ee8ba: 8328999: Update GIFlib to 5.2.2
• ... and 47 more: https://git.openjdk.org/jdk17u-dev/compare/fed9693f6d956f0cd37478cc186f8316c1ba8b59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @fitzsim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (e8434360)

[fitzsim]

/approval request I tested this backport on Windows too (with #2487 applied), and IdealGraphViewer works.

[openjdk]

@fitzsim
8279068: The approval request has been created successfully.

[gnu-andrew]

Confirmed clean.

[fitzsim]

Confirmed clean.

Thank you for reviewing.

[fitzsim]

/integrate

[openjdk]

@fitzsim
Your change (at version e843436) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit d117806.
Since your change was applied there have been 57 commits pushed to the master branch:

• 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
• ab84520: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
• d1e909f: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
• d608778: 8326106: Write and clear stack trace table outside of safepoint
• bcdb727: 8329004: Update Libpng to 1.6.43
• 08b3f72: 8312229: Crash involving yield, switch and anonymous classes
• a0c72d0: 8320692: Null icon returned for .exe without custom icon
• 352d258: 8328953: JEditorPane.read throws ChangedCharSetException
• 4d5ed55: 8332898: failure_handler: log directory of commands
• a9ee8ba: 8328999: Update GIFlib to 5.2.2
• ... and 47 more: https://git.openjdk.org/jdk17u-dev/compare/fed9693f6d956f0cd37478cc186f8316c1ba8b59...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @fitzsim Pushed as commit d117806.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.