Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307091: A few client tests intermittently throw ConcurrentModificationException #2489

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented May 23, 2024

Due to JDK-8327137 and JDK-8323670 depends on this, so i will backport this first, and then backport the others.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8307091 needs maintainer approval

Issue

  • JDK-8307091: A few client tests intermittently throw ConcurrentModificationException (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2489/head:pull/2489
$ git checkout pull/2489

Update a local copy of the PR:
$ git checkout pull/2489
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2489

View PR using the GUI difftool:
$ git pr show -t 2489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2489.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 465bdd9e416cacc6cc7dd91a29cc84adf2eaf1ed 8307091: A few client tests intermittently throw ConcurrentModificationException May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024

Webrevs

@luchenlin luchenlin closed this May 27, 2024
@TheRealMDoerr
Copy link
Contributor

Why did you close it? We should backport it before we can apply JDK-8323670.

@TheRealMDoerr
Copy link
Contributor

This one is now gating other backports. Please reopen and handle with priority.

@TheRealMDoerr
Copy link
Contributor

Seems like you don't have time at the moment. I'll take it and create a new one.

@TheRealMDoerr
Copy link
Contributor

Continued here: #2551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants