Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311666: Disabled tests in test/jdk/sun/java2d/marlin #2494

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 24, 2024

Hi all,

This pull request contains a backport of commit b285ed72 from the openjdk/jdk repository.

The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8311666 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311666: Disabled tests in test/jdk/sun/java2d/marlin (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2494/head:pull/2494
$ git checkout pull/2494

Update a local copy of the PR:
$ git checkout pull/2494
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2494

View PR using the GUI difftool:
$ git pr show -t 2494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2494.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311666: Disabled tests in test/jdk/sun/java2d/marlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 7a8cf6c: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
  • 515bc9a: 8318986: Improve GenericWaitBarrier performance
  • dcb2c35: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 8faeefc: 8289182: NMT: MemTracker::baseline should return void
  • e85eecb: 8288568: Reduce runtime of java.security microbenchmarks
  • 2d834b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • 787cf27: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
  • 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/4071b8c9be8e763d48bab1a5b8d57729a4f1307b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b285ed72aebe2d802fa9c071372cea6c09870b9a 8311666: Disabled tests in test/jdk/sun/java2d/marlin May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 28, 2024 23:27
@openjdk
Copy link

openjdk bot commented May 28, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 29, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 33ab474.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 1b807f9: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • 1ce0c63: 8324646: Avoid Class.forName in SecureRandom constructor
  • 97dbc9a: 8331746: Create a test to verify that the cmm id is not ignored
  • 235baaa: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • 5cdff9f: 8318474: Fix memory reporter for thread_count
  • a058ad1: 8315362: NMT: summary diff reports threads count incorrectly
  • 9eb9702: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • 46ba9bb: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 1de0c0a: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant"
  • eebb80c: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/4071b8c9be8e763d48bab1a5b8d57729a4f1307b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@mrserb Pushed as commit 33ab474.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant