Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288568: Reduce runtime of java.security microbenchmarks #2499

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 28, 2024

Hi all,
I backport this parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8288568 needs maintainer approval

Issue

  • JDK-8288568: Reduce runtime of java.security microbenchmarks (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2499/head:pull/2499
$ git checkout pull/2499

Update a local copy of the PR:
$ git checkout pull/2499
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2499

View PR using the GUI difftool:
$ git pr show -t 2499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2499.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288568: Reduce runtime of java.security microbenchmarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 787cf27: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
  • 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
  • c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
  • 0cfee92: 8294699: Launcher causes lingering busy cursor
  • f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d1e31f6: 8289643: File descriptor leak with ProcessBuilder.startPipeline
  • 69e6736: 8314835: gtest wrappers should be marked as flagless

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a28ab7b62abcfce56425d62d5a8162d8f1623393 8288568: Reduce runtime of java.security microbenchmarks May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 28, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Backport parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@sendaoYan
8288568: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 28, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 29, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@sendaoYan
Your change (at version 42d4101) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 29, 2024

Going to push as commit e85eecb.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 2d834b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • 787cf27: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
  • 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
  • c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
  • 0cfee92: 8294699: Launcher causes lingering busy cursor
  • f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d1e31f6: 8289643: File descriptor leak with ProcessBuilder.startPipeline
  • 69e6736: 8314835: gtest wrappers should be marked as flagless

Your commit was automatically rebased without conflicts.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2024
@openjdk openjdk bot closed this May 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@TheRealMDoerr @sendaoYan Pushed as commit e85eecb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants