8295111: dpkg appears to have problems resolving symbolically linked native libraries

[vpa1977]

Hi all,

This pull request contains a backport of commit 32946e18 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev.

The backport had a conflict in the copyright header that was resolved manually.

This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g.

dpkg -S /lib/x86_64-linux-gnu/libmd.so.0
# dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libmd.so.0

The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails.

The change is tested by jpackage set of jtreg tests and should be low risk.

jpackage tests pass (Ubuntu 24.04):

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/tools/jpackage                        55    55     0     0   
==============================
TEST SUCCESS

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8295111 needs maintainer approval

Issue

• JDK-8295111: dpkg appears to have problems resolving symbolically linked native libraries (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2501/head:pull/2501
$ git checkout pull/2501

Update a local copy of the PR:
$ git checkout pull/2501
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2501

View PR using the GUI difftool:
$ git pr show -t 2501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2501.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295111: dpkg appears to have problems resolving symbolically linked native libraries

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 8faeefc: 8289182: NMT: MemTracker::baseline should return void
• e85eecb: 8288568: Reduce runtime of java.security microbenchmarks
• 2d834b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 787cf27: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
• 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
• 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92: 8294699: Launcher causes lingering busy cursor
• f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/6c3a188d47aa738bf8faaabb10fb56b4989fc1cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @vpa1977 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (7a493699)

[vpa1977]

/approval request

[openjdk]

@vpa1977
8295111: The approval request has been created successfully.

[vpa1977]

/integrate

[openjdk]

@vpa1977
Your change (at version 7a49369) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit dcb2c35.
Since your change was applied there have been 12 commits pushed to the master branch:

• 8faeefc: 8289182: NMT: MemTracker::baseline should return void
• e85eecb: 8288568: Reduce runtime of java.security microbenchmarks
• 2d834b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 787cf27: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
• 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
• 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92: 8294699: Launcher causes lingering busy cursor
• f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/6c3a188d47aa738bf8faaabb10fb56b4989fc1cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @vpa1977 Pushed as commit dcb2c35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.