8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"

[rkmauryaa]

clean backport to remove assertion which asserts artifact is not serialized and assumes only JfrRecorderThread can perform serialization of artifacts marked during the window between rotate() and end_recording(), which is not true because a GC thread during class unloading process will serialize the class loaders associated with the unloaded classes. We should remove this assertion and let the code fall through and explicitly clear the serialize and transient meta bits.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8265919 needs maintainer approval

Issue

• JDK-8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2504/head:pull/2504
$ git checkout pull/2504

Update a local copy of the PR:
$ git checkout pull/2504
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2504

View PR using the GUI difftool:
$ git pr show -t 2504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2504.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rkmauryaa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkmauryaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92: 8294699: Launcher causes lingering busy cursor
• f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• d1e31f6: 8289643: File descriptor leak with ProcessBuilder.startPipeline
• 69e6736: 8314835: gtest wrappers should be marked as flagless

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rkmauryaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (381db0df)

[rkmauryaa]

/approval request This backport removes assertion which asserts artifact is not serialized and explicitly clear the serialize and transient meta bits, we do this because a GC thread during class unloading process can serialize the class loaders associated with the unloaded classes which causes assertion to fail.

[openjdk]

@rkmauryaa
8265919: The approval request has been created successfully.

[rkmauryaa]

/integrate

[openjdk]

@rkmauryaa
Your change (at version 381db0d) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 787cf27.
Since your change was applied there have been 8 commits pushed to the master branch:

• 24aa1e1: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• cc3f0e5: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
• 1ead7a7: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d3: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92: 8294699: Launcher causes lingering busy cursor
• f4da0e7: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• d1e31f6: 8289643: File descriptor leak with ProcessBuilder.startPipeline
• 69e6736: 8314835: gtest wrappers should be marked as flagless

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @rkmauryaa Pushed as commit 787cf27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.