Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329134: Reconsider TLAB zapping #2510

Closed
wants to merge 2 commits into from

Conversation

pengxiaolong
Copy link
Contributor

@pengxiaolong pengxiaolong commented May 31, 2024

I'd like to backport JDK-8329134 to jdk17


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329134 needs maintainer approval

Issue

  • JDK-8329134: Reconsider TLAB zapping (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2510/head:pull/2510
$ git checkout pull/2510

Update a local copy of the PR:
$ git checkout pull/2510
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2510

View PR using the GUI difftool:
$ git pr show -t 2510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2510.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2024

👋 Welcome back pengxiaolong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2024

@pengxiaolong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329134: Reconsider TLAB zapping

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 33ab474: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 1b807f9: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • 1ce0c63: 8324646: Avoid Class.forName in SecureRandom constructor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 5698f7ad29c939b7e52882ace575dd7113bf41de 8329134: Reconsider TLAB zapping May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 31, 2024

⚠️ @pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 31, 2024
@mlbridge
Copy link

mlbridge bot commented May 31, 2024

Webrevs

@pengxiaolong
Copy link
Contributor Author

pengxiaolong commented May 31, 2024

/approval request Applying for maintainer approval

@openjdk
Copy link

openjdk bot commented May 31, 2024

@pengxiaolong usage: /approval [<id>] (request|cancel) [<text>]

@pengxiaolong
Copy link
Contributor Author

/approval request Applying for maintainer approval

@openjdk
Copy link

openjdk bot commented May 31, 2024

@pengxiaolong
8329134: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 31, 2024
@pengxiaolong
Copy link
Contributor Author

/approval request Backport the fix to jdk17 to improve fastdebug tests performance; applies cleanly, apart from the NULL/nullptr conflicts; All tests passed; Risk is low: there was no follow-up bug since mainline integration 2 months and the production path should not be affected.

@openjdk
Copy link

openjdk bot commented May 31, 2024

@pengxiaolong
8329134: The approval request has been updated successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 3, 2024
@pengxiaolong
Copy link
Contributor Author

Thanks a lot! Appreciate it for the review.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@pengxiaolong
Your change (at version 2472b08) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Jun 3, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 09ad130.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 33ab474: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 1b807f9: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • 1ce0c63: 8324646: Avoid Class.forName in SecureRandom constructor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@shipilev @pengxiaolong Pushed as commit 09ad130.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pengxiaolong pengxiaolong deleted the JDK-8329134 branch June 4, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants