Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297878: KEM: Implementation #2518

Closed

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jun 3, 2024

This is the backport of the KEM API. The change is identical to openjdk/jdk17u-ri@e9d2641.

@gnu-andrew, please take a review. Thanks.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8322971 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8297878 needs maintainer approval
  • Change requires CSR request JDK-8330545 to be approved

Issues

  • JDK-8297878: KEM: Implementation (Enhancement - P3 - Approved)
  • JDK-8322971: KEM.getInstance() should check if a 3rd-party security provider is signed (Bug - P3 - Approved)
  • JDK-8330545: KEM: Implementation (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2518/head:pull/2518
$ git checkout pull/2518

Update a local copy of the PR:
$ git checkout pull/2518
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2518

View PR using the GUI difftool:
$ git pr show -t 2518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2518.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2024

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297878: KEM: Implementation
8322971: KEM.getInstance() should check if a 3rd-party security provider is signed

Reviewed-by: mullan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 243 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e9d2641a14407380264b50fa2fe299980fe5f214 8297878: KEM: Implementation Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

⚠️ @wangweij This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 3, 2024
@wangweij
Copy link
Contributor Author

wangweij commented Jun 3, 2024

/approval

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@wangweij usage: /approval [<id>] (request|cancel) [<text>]

@wangweij
Copy link
Contributor Author

wangweij commented Jun 3, 2024

/approval request Backporting KEM API to jdk17u-dev which is already integrated injdk17u-ri

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@wangweij
8297878: The approval request has been created successfully.
8322971: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 3, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting to jdk17u-dev. I can confirm this matches the patch we reviewed for 17u-ri.

@wangweij
Copy link
Contributor Author

I'll push the change on July 30, which is the first merge for 17.0.13 according to https://wiki.openjdk.org/display/JDKUpdates/JDK+17u.

@gnu-andrew
Copy link
Member

I'll push the change on July 30, which is the first merge for 17.0.13 according to https://wiki.openjdk.org/display/JDKUpdates/JDK+17u.

@wangweij there's no need to wait. All the changes for 17.0.12 are isolated in github.com/openjdk/jdk17u. If you wait until the 30th, you might actually miss the promotion of 17.0.13+1.

@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2024

Going to push as commit e49367b.
Since your change was applied there have been 280 commits pushed to the master branch:

  • 1219484: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
  • 6e93acc: 8301200: Don't scale timeout stress with timeout factor
  • aa75196: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
  • 72de151: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
  • ad6b1fa: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
  • 0644986: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
  • 9e14667: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
  • 97be07a: 8307779: Relax the java.awt.Robot specification
  • 14e3de9: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 385952c: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • ... and 270 more: https://git.openjdk.org/jdk17u-dev/compare/025969c97e8b6dc600d2935c4225d04dae6e23bf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 22, 2024
@openjdk openjdk bot closed this Jul 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2024
@openjdk
Copy link

openjdk bot commented Jul 22, 2024

@wangweij Pushed as commit e49367b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants