8297878: KEM: Implementation

[wangweij]

This is the backport of the KEM API. The change is identical to openjdk/jdk17u-ri@e9d2641.

@gnu-andrew, please take a review. Thanks.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8322971 needs maintainer approval
• Commit message must refer to an issue
• JDK-8297878 needs maintainer approval
• Change requires CSR request JDK-8330545 to be approved

Issues

• JDK-8297878: KEM: Implementation (Enhancement - P3 - Approved)
• JDK-8322971: KEM.getInstance() should check if a 3rd-party security provider is signed (Bug - P3 - Approved)
• JDK-8330545: KEM: Implementation (CSR)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2518/head:pull/2518
$ git checkout pull/2518

Update a local copy of the PR:
$ git checkout pull/2518
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2518

View PR using the GUI difftool:
$ git pr show -t 2518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2518.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297878: KEM: Implementation
8322971: KEM.getInstance() should check if a 3rd-party security provider is signed

Reviewed-by: mullan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 243 new commits pushed to the master branch:

• 05bea0e: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
• 7dcb608: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
• c915eaf: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
• 3d83f3e: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
• 1e63af9: 8300806: Update googletest to v1.13.0
• e809008: 8300910: Remove metaprogramming/integralConstant.hpp
• 952d272: 8300265: Remove metaprogramming/isSigned.hpp
• f9acc53: 8300260: Remove metaprogramming/isSame.hpp
• 3069e3e: 8305959: x86: Improve itable_stub
• e43402d: 8335918: update for deprecated sprintf for jvmti
• ... and 233 more: https://git.openjdk.org/jdk17u-dev/compare/025969c97e8b6dc600d2935c4225d04dae6e23bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[openjdk]

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

[mlbridge]

Webrevs

• 00: Full (81138a0d)

[openjdk]

⚠️ @wangweij This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[wangweij]

/approval

[openjdk]

@wangweij usage: /approval [<id>] (request|cancel) [<text>]

[wangweij]

/approval request Backporting KEM API to jdk17u-dev which is already integrated injdk17u-ri

[openjdk]

@wangweij
8297878: The approval request has been created successfully.
8322971: The approval request has been created successfully.

[gnu-andrew]

Thanks for porting to jdk17u-dev. I can confirm this matches the patch we reviewed for 17u-ri.

[wangweij]

I'll push the change on July 30, which is the first merge for 17.0.13 according to https://wiki.openjdk.org/display/JDKUpdates/JDK+17u.

[gnu-andrew]

I'll push the change on July 30, which is the first merge for 17.0.13 according to https://wiki.openjdk.org/display/JDKUpdates/JDK+17u.

@wangweij there's no need to wait. All the changes for 17.0.12 are isolated in github.com/openjdk/jdk17u. If you wait until the 30th, you might actually miss the promotion of 17.0.13+1.

[wangweij]

/integrate

[openjdk]

Going to push as commit e49367b.
Since your change was applied there have been 280 commits pushed to the master branch:

• 1219484: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
• 6e93acc: 8301200: Don't scale timeout stress with timeout factor
• aa75196: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
• 72de151: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
• ad6b1fa: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
• 0644986: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
• 9e14667: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
• 97be07a: 8307779: Relax the java.awt.Robot specification
• 14e3de9: 8319103: Popups that request focus are not shown on Linux with Wayland
• 385952c: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• ... and 270 more: https://git.openjdk.org/jdk17u-dev/compare/025969c97e8b6dc600d2935c4225d04dae6e23bf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit e49367b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.