Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 3, 2024

Backport of JDK-8305825. Problem list update required manual integration. Skipped hunk in XDecoratedPeer.java which belongs to JDK-8267307 which is not in 17u. The rest applies cleanly. Please review!

It would be great if anybody could test it on Ubuntu 23.04 or newer. I don't have it.
Note: MultiResolutionSplashTest.java is problem listed in 17u: 8061235 macosx-all


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8305825 needs maintainer approval

Issue

  • JDK-8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2526/head:pull/2526
$ git checkout pull/2526

Update a local copy of the PR:
$ git checkout pull/2526
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2526/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2526

View PR using the GUI difftool:
$ git pr show -t 2526

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2526.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 05e645e: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • b275236: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 44ade1d: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
  • 0fa4d91: 8310201: Reduce verbose locale output in -XshowSettings launcher option
  • 95432a6: 8322008: Exclude some CDS tests from running with -Xshare:off
  • 9c89f1c: 8320945: problemlist tests failing on latest Windows 11 update
  • 09ad130: 8329134: Reconsider TLAB zapping
  • 33ab474: 8311666: Disabled tests in test/jdk/sun/java2d/marlin

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7723611d5d5f8959d69d1000fa117166e3d3c5fb 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 17.0.12-oracle. In JDK 17, only one file needs the update which applies cleanly. It has already been shipped to customers with JDK 22 and backported to 21.0.5. I can't test on Ubuntu 23.04 because I don't have it. Running the headful tests on other OSes didn't show any regression.

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

@TheRealMDoerr
8305825: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 4, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

Going to push as commit ab84520.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2024
@openjdk openjdk bot closed this Jun 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@TheRealMDoerr Pushed as commit ab84520.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8267307_X11 branch June 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants