-
Notifications
You must be signed in to change notification settings - Fork 232
8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Should get backported for parity with 17.0.12-oracle. In JDK 17, only one file needs the update which applies cleanly. It has already been shipped to customers with JDK 22 and backported to 21.0.5. I can't test on Ubuntu 23.04 because I don't have it. Running the headful tests on other OSes didn't show any regression. |
|
@TheRealMDoerr |
|
/integrate |
|
Going to push as commit ab84520.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit ab84520. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8305825. Problem list update required manual integration. Skipped hunk in XDecoratedPeer.java which belongs to JDK-8267307 which is not in 17u. The rest applies cleanly. Please review!
It would be great if anybody could test it on Ubuntu 23.04 or newer. I don't have it.
Note: MultiResolutionSplashTest.java is problem listed in 17u: 8061235 macosx-all
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2526/head:pull/2526$ git checkout pull/2526Update a local copy of the PR:
$ git checkout pull/2526$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2526/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2526View PR using the GUI difftool:
$ git pr show -t 2526Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2526.diff
Webrev
Link to Webrev Comment