-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332898: failure_handler: log directory of commands #2532
8332898: failure_handler: log directory of commands #2532
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Should get backported for parity with 17.0.13-oracle. Applies cleanly. Tier 1-4 have passed. |
@TheRealMDoerr |
/integrate |
Going to push as commit 4d5ed55.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 4d5ed55. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8332898.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2532/head:pull/2532
$ git checkout pull/2532
Update a local copy of the PR:
$ git checkout pull/2532
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2532/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2532
View PR using the GUI difftool:
$ git pr show -t 2532
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2532.diff
Webrev
Link to Webrev Comment