Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294148: Support JSplitPane for instructions and test UI #2534

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jun 4, 2024

I backport this for parity with 17.0.13-oracle.


Progress

  • JDK-8294148 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294148: Support JSplitPane for instructions and test UI (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2534/head:pull/2534
$ git checkout pull/2534

Update a local copy of the PR:
$ git checkout pull/2534
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2534

View PR using the GUI difftool:
$ git pr show -t 2534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2534.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294148: Support JSplitPane for instructions and test UI

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
  • ab84520: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • d1e909f: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • d608778: 8326106: Write and clear stack trace table outside of safepoint
  • bcdb727: 8329004: Update Libpng to 1.6.43
  • 08b3f72: 8312229: Crash involving yield, switch and anonymous classes
  • a0c72d0: 8320692: Null icon returned for .exe without custom icon
  • 352d258: 8328953: JEditorPane.read throws ChangedCharSetException
  • 4d5ed55: 8332898: failure_handler: log directory of commands
  • a9ee8ba: 8328999: Update GIFlib to 5.2.2
  • ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/97dbc9ada48a590d8c215ed62035d6383d35f3b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b419e9517361ed9d28f8ab2f5beacf5adfe3db91 8294148: Support JSplitPane for instructions and test UI Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 5, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

Going to push as commit 8414ee3.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 36384e8: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • cda3768: 8326734: text-decoration applied to lost when mixed with or
  • bc857cb: 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS
  • bcd19a5: 8333698: [17u] TestJstatdRmiPort fails after JDK-8333667
  • 2d9b1a6: 8303942: os::write should write completely
  • 17d65fe: 8305072: Win32ShellFolder2.compareTo is inconsistent
  • ffa8a10: 8292948: JEditorPane ignores font-size styles in external linked css-file
  • 541a284: 8322726: C2: Unloaded signature class kills argument value
  • 43a6746: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • ... and 33 more: https://git.openjdk.org/jdk17u-dev/compare/97dbc9ada48a590d8c215ed62035d6383d35f3b7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 11, 2024
@openjdk openjdk bot closed this Jun 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@luchenlin Pushed as commit 8414ee3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant