Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325179: Race in BasicDirectoryModel.validateFileCache #2539

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2024

Clean backport of JDK-8325179 after JDK-8323670 is integrated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8325179 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8238169 needs maintainer approval

Issues

  • JDK-8325179: Race in BasicDirectoryModel.validateFileCache (Bug - P3)
  • JDK-8238169: BasicDirectoryModel getDirectories and DoChangeContents.run can deadlock (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2539/head:pull/2539
$ git checkout pull/2539

Update a local copy of the PR:
$ git checkout pull/2539
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2539

View PR using the GUI difftool:
$ git pr show -t 2539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2539.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e66788c16563d343f6cccd2807a251ccc6f9b64a 8325179: Race in BasicDirectoryModel.validateFileCache Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 5, 2024
@TheRealMDoerr TheRealMDoerr marked this pull request as draft June 5, 2024 14:10
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 5, 2024
@TheRealMDoerr TheRealMDoerr deleted the 8325179_BasicDirectoryModel.validateFileCache branch June 6, 2024 10:49
@TheRealMDoerr TheRealMDoerr restored the 8325179_BasicDirectoryModel.validateFileCache branch June 10, 2024 09:06
@TheRealMDoerr
Copy link
Contributor Author

Continued here: #2558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant