8322726: C2: Unloaded signature class kills argument value

[TheRealMDoerr]

Backport of JDK-8322726. Applies cleanly, but requires two tiny adaptations (also see 2nd commit):

• sig_type->is_loaded() can only be used after JDK-8275201 which is not in 17u. Replaced it by sig_type->klass()->is_loaded() which is equivalent.
• The ClassWriter needs to write V17 compatible code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8322726 needs maintainer approval

Issue

• JDK-8322726: C2: Unloaded signature class kills argument value (Bug - P2 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2540/head:pull/2540
$ git checkout pull/2540

Update a local copy of the PR:
$ git checkout pull/2540
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2540

View PR using the GUI difftool:
$ git pr show -t 2540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2540.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322726: C2: Unloaded signature class kills argument value

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• ce19e61: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• af699ff: 8325567: jspawnhelper without args fails with segfault
• a86a221: 8329995: Restricted access to /proc can cause JFR initialization to crash
• 28aa19e: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 9aa7b2f: 8279337: The MToolkit is still referenced in a few places
• 2db1501: 8323801: tag doesn't strikethrough the text
• 5377458: 8005885: enhance PrintCodeCache to print more data
• d23f4d6: 8282526: Default icon is not painted properly
• d117806: 8279068: IGV: Update to work with JDK 16 and 17
• 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c2a98038)
• 00: Full (44e552eb)

[TheRealMDoerr]

Thanks for the review!

[TheRealMDoerr]

/approval request Should get backported for parity with 17.0.13-oracle. The backport requires very small adaptations which have been reviewed. Tier1-4 have passed.

[openjdk]

@TheRealMDoerr
8322726: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 541a284.
Since your change was applied there have been 11 commits pushed to the master branch:

• 43a6746: 8307091: A few client tests intermittently throw ConcurrentModificationException
• ce19e61: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• af699ff: 8325567: jspawnhelper without args fails with segfault
• a86a221: 8329995: Restricted access to /proc can cause JFR initialization to crash
• 28aa19e: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 9aa7b2f: 8279337: The MToolkit is still referenced in a few places
• 2db1501: 8323801: tag doesn't strikethrough the text
• 5377458: 8005885: enhance PrintCodeCache to print more data
• d23f4d6: 8282526: Default icon is not painted properly
• d117806: 8279068: IGV: Update to work with JDK 16 and 17
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/ab84520d73a63601d75e45895663d8216ca20962...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 541a284.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.