Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323801: <s> tag doesn't strikethrough the text #2541

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2024

Backport of JDK-8323801. Clean except Copyright year change.


Progress

  • JDK-8323801 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323801: <s> tag doesn't strikethrough the text (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2541/head:pull/2541
$ git checkout pull/2541

Update a local copy of the PR:
$ git checkout pull/2541
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2541

View PR using the GUI difftool:
$ git pr show -t 2541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2541.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323801: <s> tag doesn't strikethrough the text

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d117806: 8279068: IGV: Update to work with JDK 16 and 17
  • 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 80b63b67293970936d57ae4375ad76cd2b11a333 8323801: <s> tag doesn't strikethrough the text Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 17.0.13-oracle. Applies cleanly (except Copyright year update) and tier1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@TheRealMDoerr
8323801: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 6, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit 2db1501.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 5377458: 8005885: enhance PrintCodeCache to print more data
  • d23f4d6: 8282526: Default icon is not painted properly
  • d117806: 8279068: IGV: Update to work with JDK 16 and 17
  • 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2024
@TheRealMDoerr TheRealMDoerr deleted the 8323801_HTML_strikethrough branch June 6, 2024 09:46
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@TheRealMDoerr Pushed as commit 2db1501.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant