Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272317: jstatd has dependency on Security Manager which needs to be removed #2542

Closed
wants to merge 3 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 6, 2024

Semi-clean backport to resolve the jstatd dependency on SM. Current jstatd tests are also failing because some recently backported tests do not expect SM deprecation messages, see JDK-8333698.

This also reverts 17u-specific test amendment, JDK-8272317.

Additional testing:

  • MacOS AArch64 server fastdebug, sun/tools/jstatd/ now pass

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8272317 needs maintainer approval
  • Change requires CSR request JDK-8333700 to be approved

Issues

  • JDK-8272317: jstatd has dependency on Security Manager which needs to be removed (Enhancement - P3)
  • JDK-8333700: jstatd has dependency on Security Manager which needs to be removed (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2542/head:pull/2542
$ git checkout pull/2542

Update a local copy of the PR:
$ git checkout pull/2542
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2542

View PR using the GUI difftool:
$ git pr show -t 2542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2542.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport cb8a82ee24881113af4eea04d7ce5963d18e9b83 8272317: jstatd has dependency on Security Manager which needs to be removed Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants