Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333765: [17u] Six sun/tools/jstatd testcases fail after JDK-8233725 #2548

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 7, 2024

Hi all,
The below 6 sun/tools/jstatd testcases fail after JDK-8233725:

sun/tools/jstatd/TestJstatdExternalRegistry.java
sun/tools/jstatd/TestJstatdPort.java
sun/tools/jstatd/TestJstatdPortAndServer.java
sun/tools/jstatd/TestJstatdRmiPort.java
sun/tools/jstatd/TestJstatdDefaults.java
sun/tools/jstatd/TestJstatdServer.java

As descript in JDK-8333765, the jdk17 has several additional [Jstatd-Thread] WARNING:, these warning messages can't deal with by asLinesWithoutVMWarnings(), so I add asLinesWithoutAnythingWarnings() to deal these warning messages. Only change the testcases, the risk is low.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333765 needs maintainer approval

Issue

  • JDK-8333765: [17u] Six sun/tools/jstatd testcases fail after JDK-8233725 (Bug - P3) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2548/head:pull/2548
$ git checkout pull/2548

Update a local copy of the PR:
$ git checkout pull/2548
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2548

View PR using the GUI difftool:
$ git pr show -t 2548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2548.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2024

Webrevs

@shipilev
Copy link
Member

Hold on, we have already fixed/integrated https://bugs.openjdk.org/browse/JDK-8333698 that should resolve this.

Are you seeing more problems after JDK-8333698?

@sendaoYan
Copy link
Member Author

Hold on, we have already fixed/integrated https://bugs.openjdk.org/browse/JDK-8333698 that should resolve this.

Are you seeing more problems after JDK-8333698?

After JDK-8333698 the 6 testcases run succssed. I think this PR could close.

@sendaoYan sendaoYan closed this Jun 10, 2024
@sendaoYan sendaoYan deleted the jbs8333765 branch June 24, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants