Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307091: A few client tests intermittently throw ConcurrentModificationException #2551

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 7, 2024

Clean backport of JDK-8307091. This fix is superseded by JDK-8323670, but required for that one to apply.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8307091 needs maintainer approval

Issue

  • JDK-8307091: A few client tests intermittently throw ConcurrentModificationException (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2551/head:pull/2551
$ git checkout pull/2551

Update a local copy of the PR:
$ git checkout pull/2551
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2551

View PR using the GUI difftool:
$ git pr show -t 2551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2551.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307091: A few client tests intermittently throw ConcurrentModificationException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • ce19e61: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • af699ff: 8325567: jspawnhelper without args fails with segfault
  • a86a221: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • 28aa19e: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 9aa7b2f: 8279337: The MToolkit is still referenced in a few places
  • 2db1501: 8323801: tag doesn't strikethrough the text
  • 5377458: 8005885: enhance PrintCodeCache to print more data
  • d23f4d6: 8282526: Default icon is not painted properly
  • d117806: 8279068: IGV: Update to work with JDK 16 and 17
  • 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
  • ... and 19 more: https://git.openjdk.org/jdk17u-dev/compare/09ad130fd4f40278e8b228853c9a4b662521c01d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 465bdd9e416cacc6cc7dd91a29cc84adf2eaf1ed 8307091: A few client tests intermittently throw ConcurrentModificationException Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

The previous PR was already successfully tested (Tier 1-4).

@TheRealMDoerr
Copy link
Contributor Author

/approval request This backport is needed for JDK-8323670 to apply. I guess that the backports were bundled in 17.0.13-oracle. Applies cleanly and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@TheRealMDoerr
8307091: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 7, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

Going to push as commit 43a6746.
Since your change was applied there have been 29 commits pushed to the master branch:

  • ce19e61: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • af699ff: 8325567: jspawnhelper without args fails with segfault
  • a86a221: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • 28aa19e: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 9aa7b2f: 8279337: The MToolkit is still referenced in a few places
  • 2db1501: 8323801: tag doesn't strikethrough the text
  • 5377458: 8005885: enhance PrintCodeCache to print more data
  • d23f4d6: 8282526: Default icon is not painted properly
  • d117806: 8279068: IGV: Update to work with JDK 16 and 17
  • 7d0d793: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
  • ... and 19 more: https://git.openjdk.org/jdk17u-dev/compare/09ad130fd4f40278e8b228853c9a4b662521c01d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2024
@openjdk openjdk bot closed this Jun 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@TheRealMDoerr Pushed as commit 43a6746.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant