8331885: C2: meet between unloaded and speculative types is not symmetric

[TheRealMDoerr]

Backport of JDK-8331885. Manual integration was needed. I had to omit _interfaces in TypeInstPtr::with_speculative because JDK-8297933 is not in 17u. The context differs to some degree, but all modifications are integrated (each line). The test update applies cleanly. Please review!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8331885 needs maintainer approval

Issue

• JDK-8331885: C2: meet between unloaded and speculative types is not symmetric (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2554/head:pull/2554
$ git checkout pull/2554

Update a local copy of the PR:
$ git checkout pull/2554
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2554

View PR using the GUI difftool:
$ git pr show -t 2554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2554.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331885: C2: meet between unloaded and speculative types is not symmetric

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 8414ee3: 8294148: Support JSplitPane for instructions and test UI
• 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 36384e8: 8323670: A few client tests intermittently throw ConcurrentModificationException
• cda3768: 8326734: text-decoration applied to lost when mixed with or
• bc857cb: 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS
• bcd19a5: 8333698: [17u] TestJstatdRmiPort fails after JDK-8333667
• 2d9b1a6: 8303942: os::write should write completely

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (234ffd88)

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TheRealMDoerr]

Thanks for the review!

[TheRealMDoerr]

/approval request Should get backported for parity with 17.0.13-oracle. It doesn't apply cleanly, but has been reviewed. Tier 1-4 have passed.

[openjdk]

@TheRealMDoerr
8331885: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 92daaf2.
Since your change was applied there have been 7 commits pushed to the master branch:

• 8414ee3: 8294148: Support JSplitPane for instructions and test UI
• 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 36384e8: 8323670: A few client tests intermittently throw ConcurrentModificationException
• cda3768: 8326734: text-decoration applied to lost when mixed with or
• bc857cb: 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS
• bcd19a5: 8333698: [17u] TestJstatdRmiPort fails after JDK-8333667
• 2d9b1a6: 8303942: os::write should write completely

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 92daaf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.