Skip to content

8333477: Delete extra empty spaces in Makefiles #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 8, 2024

Hi all,
This is clean backport to delete several extra trailing whitespaces and extra trailing lines in several Makefiles. It's trivial fix, no risk.
The commit being backported was authored by SendaoYan on 7 Jun 2024 and was reviewed by Erik Joelsson, Christian Hagedorn, Chen Liang and Julian Waters.

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333477 needs maintainer approval

Issue

  • JDK-8333477: Delete extra empty spaces in Makefiles (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2555/head:pull/2555
$ git checkout pull/2555

Update a local copy of the PR:
$ git checkout pull/2555
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2555

View PR using the GUI difftool:
$ git pr show -t 2555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2555.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333477: Delete extra empty spaces in Makefiles

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 8414ee3: 8294148: Support JSplitPane for instructions and test UI
  • 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 36384e8: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • cda3768: 8326734: text-decoration applied to lost when mixed with or
  • bc857cb: 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d130d2f4f46d37a2b924343de19d012c129b0a55 8333477: Delete extra empty spaces in Makefiles Jun 8, 2024
@openjdk
Copy link

openjdk bot commented Jun 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to delete several extra trailing whitespaces and extra trailing lines in several Makefiles. It's trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

@sendaoYan
8333477: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 8, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@sendaoYan
Your change (at version 4fb51a2) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

Going to push as commit 08c3774.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • d953de6: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • bc5639a: 8325179: Race in BasicDirectoryModel.validateFileCache
  • d3c1ad3: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • 7bc22f7: 8279164: Disable TLS_ECDH_* cipher suites
  • d99641e: 7124313: [macosx] Swing Popups should overlap taskbar
  • 92daaf2: 8331885: C2: meet between unloaded and speculative types is not symmetric
  • 8414ee3: 8294148: Support JSplitPane for instructions and test UI
  • 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/bcd19a5b12651ca0ae8e1a35a2838738e119c730...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2024
@openjdk openjdk bot closed this Jun 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@TheRealMDoerr @sendaoYan Pushed as commit 08c3774.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the approved and sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants