8324668: JDWP process management needs more efficient file descriptor handling

[dimitryc]

The original patch applies almost cleanly except for copyright years

Additional testing: passed local test1-4 testing on macos-aarch64

It's needed as a prerequisite to fix JDK-8324577 (already backported to JDK 21)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324668 needs maintainer approval

Issue

• JDK-8324668: JDWP process management needs more efficient file descriptor handling (Enhancement - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2557/head:pull/2557
$ git checkout pull/2557

Update a local copy of the PR:
$ git checkout pull/2557
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2557

View PR using the GUI difftool:
$ git pr show -t 2557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2557.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dimitryc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324668: JDWP process management needs more efficient file descriptor handling

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
• 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
• d953de6: 8313394: Array Elements in OldObjectSample event has the incorrect description
• bc5639a: 8325179: Race in BasicDirectoryModel.validateFileCache
• d3c1ad3: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• 7bc22f7: 8279164: Disable TLS_ECDH_* cipher suites
• d99641e: 7124313: [macosx] Swing Popups should overlap taskbar
• 92daaf2: 8331885: C2: meet between unloaded and speculative types is not symmetric
• 8414ee3: 8294148: Support JSplitPane for instructions and test UI
• 6910365: 8316104: Open source several Swing SplitPane and RadioButton related tests
• ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/7d0d793ea51e7996ec716034841c88ec4d1cd6b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (d9445dae)

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @dimitryc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[dimitryc]

Thanks for the review!

[dimitryc]

/approval request This is a prerequisite change for JDK-8324577 (already backported to JDK 21). Applies cleanly except for copyright years. Passes local tier1-4 testing on macos-aarch64.

[openjdk]

@dimitryc
8324668: The approval request has been created successfully.

[RealCLanger]

@dimitryc Looks like this PR is not recognized as backport - I guess you have to fix this as described above. (Set the PR title to Backport with the hash of the original commit)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[dimitryc]

@dimitryc Looks like this PR is not recognized as backport - I guess you have to fix this as described above. (Set the PR title to Backport with the hash of the original commit)

Thanks! Updated the PR title. Looks like it's recognized as backport now.

[dimitryc]

/integrate

[openjdk]

Going to push as commit f9c11cb.
Since your change was applied there have been 30 commits pushed to the master branch:

• 0a4f926: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
• 08c3774: 8333477: Delete extra empty spaces in Makefiles
• 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
• 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
• d953de6: 8313394: Array Elements in OldObjectSample event has the incorrect description
• bc5639a: 8325179: Race in BasicDirectoryModel.validateFileCache
• d3c1ad3: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• 7bc22f7: 8279164: Disable TLS_ECDH_* cipher suites
• d99641e: 7124313: [macosx] Swing Popups should overlap taskbar
• 92daaf2: 8331885: C2: meet between unloaded and speculative types is not symmetric
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/7d0d793ea51e7996ec716034841c88ec4d1cd6b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dimitryc Pushed as commit f9c11cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.