-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279164: Disable TLS_ECDH_* cipher suites #2559
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Thanks for the review! |
/approval request Should get backported for parity with 17.0.13-oracle. The backport has been reviewed and tier 1-4 have passed. |
@TheRealMDoerr |
/integrate |
Going to push as commit 7bc22f7.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 7bc22f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I believe there's an error in this backport. In trunk, the change in
and
In backporting to 17u, changes related to 3DES from JDK-8163327 have been incorporated that don't belong in this fix.
and
We shouldn't be adding 3DES here. This is not part of this PR. I'll file a bug to get this fixed. It also seems to affect the 11u backport. I spotted this when reviewing the 8u one, which, being based on trunk, did not have this addition when compared with the 11u one. |
You're right. |
Backport of JDK-8279164. The test changes in DisabledAlgorithms.java needed manual integration. The rest applies cleanly.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2559/head:pull/2559
$ git checkout pull/2559
Update a local copy of the PR:
$ git checkout pull/2559
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2559/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2559
View PR using the GUI difftool:
$ git pr show -t 2559
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2559.diff
Webrev
Link to Webrev Comment