Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories #256

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 15, 2022

I backport this for parity with 17.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
  • JDK-8277166: Data race in jdeps VersionHelper
  • JDK-8277123: jdeps does not report some exceptions correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/256/head:pull/256
$ git checkout pull/256

Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 256

View PR using the GUI difftool:
$ git pr show -t 256

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/256.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7e54d065a17f1277adf1b8561fadb8a480bc6bed 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
8277166: Data race in jdeps VersionHelper
8277123: jdeps does not report some exceptions correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit defd25c.
Since your change was applied there have been 10 commits pushed to the master branch:

  • e955760: 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows
  • ee7a603: 8274751: Drag And Drop hangs on Windows
  • f67a3a5: 8279834: Alpine Linux fails to build when --with-source-date enabled
  • 60d085e: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions
  • cf2a7ab: 8281318: Improve jfr/event/allocation tests reliability
  • 5d1969b: 8277893: Arraycopy stress tests
  • 4f0d711: 8281615: Deadlock caused by jdwp agent
  • 943c2b3: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date
  • 7b65a39: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency
  • 3521504: 8283017: GHA: Workflows break with update release versions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@GoeLin Pushed as commit defd25c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant