Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." #2564

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jun 11, 2024

I backport this for parity with 17.0.13-oracle.
java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java 8280392 windows-x64
not in problem.txt make it clean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280392 needs maintainer approval

Issue

  • JDK-8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2564/head:pull/2564
$ git checkout pull/2564

Update a local copy of the PR:
$ git checkout pull/2564
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2564

View PR using the GUI difftool:
$ git pr show -t 2564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2564.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • f9c11cb: 8324668: JDWP process management needs more efficient file descriptor handling
  • 0a4f926: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 08c3774: 8333477: Delete extra empty spaces in Makefiles
  • 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • d953de6: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • bc5639a: 8325179: Race in BasicDirectoryModel.validateFileCache
  • d3c1ad3: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • 7bc22f7: 8279164: Disable TLS_ECDH_* cipher suites
  • d99641e: 7124313: [macosx] Swing Popups should overlap taskbar
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/8414ee30ff4fcc191f46b07110960dbb6e215524...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@luchenlin
Copy link
Author

/clean

@openjdk openjdk bot added the clean label Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@luchenlin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 12, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

Going to push as commit 8c80c8f.
Since your change was applied there have been 11 commits pushed to the master branch:

  • f9c11cb: 8324668: JDWP process management needs more efficient file descriptor handling
  • 0a4f926: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 08c3774: 8333477: Delete extra empty spaces in Makefiles
  • 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • d953de6: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • bc5639a: 8325179: Race in BasicDirectoryModel.validateFileCache
  • d3c1ad3: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • 7bc22f7: 8279164: Disable TLS_ECDH_* cipher suites
  • d99641e: 7124313: [macosx] Swing Popups should overlap taskbar
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/8414ee30ff4fcc191f46b07110960dbb6e215524...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2024
@openjdk openjdk bot closed this Jun 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@luchenlin Pushed as commit 8c80c8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant