Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java #2569

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 12, 2024

Hi all,

This pull request contains a backport of commit 74758248 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 8 Apr 2024 and was reviewed by Abhishek Kumar and Dmitry Markov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329510 needs maintainer approval

Issue

  • JDK-8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2569/head:pull/2569
$ git checkout pull/2569

Update a local copy of the PR:
$ git checkout pull/2569
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2569

View PR using the GUI difftool:
$ git pr show -t 2569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2569.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 747582484ce89e16661ef917a89adb52f5adc2e6 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review June 12, 2024 00:52
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 12, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 13, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

Going to push as commit 4976dc8.
Since your change was applied there have been 10 commits pushed to the master branch:

  • dad6c6b: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
  • b46208d: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9056b3b: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 257d5ef: 8316240: Open source several add/remove MenuBar manual tests
  • 8c80c8f: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
  • f9c11cb: 8324668: JDWP process management needs more efficient file descriptor handling
  • 0a4f926: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 08c3774: 8333477: Delete extra empty spaces in Makefiles
  • 938efc0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 433fc2f: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2024
@openjdk openjdk bot closed this Jun 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@mrserb Pushed as commit 4976dc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant