Skip to content

8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jun 13, 2024

I backport this for parity with 17.0.13-oracle.
‘ try (var executor = Executors.newCachedThreadPool())’ is modified due to it's not supported in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8269428 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2577/head:pull/2577
$ git checkout pull/2577

Update a local copy of the PR:
$ git checkout pull/2577
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2577

View PR using the GUI difftool:
$ git pr show -t 2577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2577.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 4976dc8: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • dad6c6b: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
  • b46208d: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9056b3b: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 257d5ef: 8316240: Open source several add/remove MenuBar manual tests
  • 8c80c8f: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 570ad67204a55dd4b45e04e5a91671fed2cc18d0 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 13, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you had to replace the try-with-resource implementation because ExecutorService doesn't implement AutoClosable in 17u. LGTM.

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 14, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit d981bc4.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 4976dc8: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • dad6c6b: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
  • b46208d: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9056b3b: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 257d5ef: 8316240: Open source several add/remove MenuBar manual tests
  • 8c80c8f: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@luchenlin Pushed as commit d981bc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants