-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance #2581
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
@amosshi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for backporting!
|
/approval request "Backporting for parity with 17.0.13-oracle. No risk, test fix. Un-Clean backport. Test passes in dev machine and pipeline” |
/integrate |
Going to push as commit 46cefca.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8294994
git patch
resultconsidered as clean
Testing
i18n.java
: Test results: passed: 1jtreg_jdk_tier2
SKIPPED
[Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]SKIPPED
[Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]SKIPPED
[Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]SKIPPED
[Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2581/head:pull/2581
$ git checkout pull/2581
Update a local copy of the PR:
$ git checkout pull/2581
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2581/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2581
View PR using the GUI difftool:
$ git pr show -t 2581
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2581.diff
Webrev
Link to Webrev Comment