Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712 #2585

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Jun 14, 2024

Backport of JDK-8305081

Testing

  • Local: Test passed on MacOS 14.5
    • Test8168712.java: Test results: passed: 2
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-06-20
    • jtreg_hotspot_tier1
      • compiler/runtime/Test8168712.java#with-dtrace: SKIPPED [Filter: Composite Filter - Filtered out by a composite filter.] GitHub 📊 - [0 msec]
      • compiler/runtime/Test8168712.java#without-dtrace: SUCCESSFUL GitHub 📊⏲ - [860 msec]

Progress

  • Change must not contain extraneous whitespace
  • JDK-8305081 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712 (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2585/head:pull/2585
$ git checkout pull/2585

Update a local copy of the PR:
$ git checkout pull/2585
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2585

View PR using the GUI difftool:
$ git pr show -t 2585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2585.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 33dbf71: 8293872: Make runtime/Thread/ThreadCountLimit.java more robust
  • e996135: 8320079: The ArabicBox.java test has no control buttons
  • 3df08b2: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • 04aa5f8: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 20ee52e: 8331063: Some HttpClient tests don't report leaks
  • c2dd771: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
  • d41ad82: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 544ab78: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
  • 4621d59: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 978b793: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • ... and 19 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 39dc40fed4e1af3e77355fa9f4abb0c72279a140 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712 Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Jun 20, 2024

/approval request "Backporting for parity with 17.0.13-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-06-20”

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@amosshi
8305081: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 20, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Jun 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2024

Going to push as commit 01cb648.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 5a40a44: 8305079: Remove finalize() from compiler/c2/Test719030
  • 858416c: 8277042: add test for 8276036 to compiler/codecache
  • c4d6967: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
  • 46cefca: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
  • 82e85fd: 8327840: Automate javax/swing/border/Test4129681.java
  • 33dbf71: 8293872: Make runtime/Thread/ThreadCountLimit.java more robust
  • e996135: 8320079: The ArabicBox.java test has no control buttons
  • 3df08b2: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • 04aa5f8: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 20ee52e: 8331063: Some HttpClient tests don't report leaks
  • ... and 24 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2024
@openjdk openjdk bot closed this Jun 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2024
@openjdk
Copy link

openjdk bot commented Jun 23, 2024

@amosshi Pushed as commit 01cb648.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8305081 branch June 23, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant