8325621: Improve jspawnhelper version checks

[chadrako]

Backport JDK-8325621

Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. Updated test passes. Already backported to 21 and 22. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325621 needs maintainer approval

Issue

• JDK-8325621: Improve jspawnhelper version checks (Enhancement - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2592/head:pull/2592
$ git checkout pull/2592

Update a local copy of the PR:
$ git checkout pull/2592
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2592

View PR using the GUI difftool:
$ git pr show -t 2592

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2592.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325621: Improve jspawnhelper version checks

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 0fc9b02: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
• d981bc4: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @chadrako This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (edb08825)

[chadrako]

/approval 8325621 request Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper.

[openjdk]

@chadrako
8325621: The approval request has been created successfully.

[chadrako]

/integrate

[openjdk]

@chadrako
Your change (at version edb0882) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit d056b73.
Since your change was applied there have been 3 commits pushed to the master branch:

• 0fc9b02: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
• d981bc4: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @chadrako Pushed as commit d056b73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.