Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE #2595

Closed
wants to merge 1 commit into from

Conversation

dimitryc
Copy link

@dimitryc dimitryc commented Jun 17, 2024

Clean backport of JDK-8324577


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324577 needs maintainer approval

Issue

  • JDK-8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2595/head:pull/2595
$ git checkout pull/2595

Update a local copy of the PR:
$ git checkout pull/2595
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2595

View PR using the GUI difftool:
$ git pr show -t 2595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2595.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@dimitryc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 4976dc8: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • dad6c6b: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
  • b46208d: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9056b3b: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 257d5ef: 8316240: Open source several add/remove MenuBar manual tests
  • 8c80c8f: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f1d0e715b67e2ca47b525069d8153abbb33f75b9 8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

⚠️ @dimitryc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@dimitryc
Copy link
Author

/approval request Sets higher macOS limit for file descriptions. Clean backport. Passes local tier1-4 testing in macos-aarch64.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@dimitryc
8324577: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 17, 2024
@dimitryc
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

Going to push as commit ed56f5b.
Since your change was applied there have been 10 commits pushed to the master branch:

  • d056b73: 8325621: Improve jspawnhelper version checks
  • 0fc9b02: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
  • d981bc4: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 4cee9be: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 4976dc8: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • dad6c6b: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
  • b46208d: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • 9056b3b: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 257d5ef: 8316240: Open source several add/remove MenuBar manual tests
  • 8c80c8f: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 18, 2024
@openjdk openjdk bot closed this Jun 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@dimitryc Pushed as commit ed56f5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8324577 branch June 18, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant