Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329663: hs_err file event log entry for thread adding/removing should print current thread #2596

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 17, 2024

Backport of 8329663; patch now goes to thread.cpp that's a difference to higher releases


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329663 needs maintainer approval

Issue

  • JDK-8329663: hs_err file event log entry for thread adding/removing should print current thread (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2596/head:pull/2596
$ git checkout pull/2596

Update a local copy of the PR:
$ git checkout pull/2596
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2596

View PR using the GUI difftool:
$ git pr show -t 2596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2596.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329663: hs_err file event log entry for thread adding/removing should print current thread

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 33dbf71: 8293872: Make runtime/Thread/ThreadCountLimit.java more robust
  • e996135: 8320079: The ArabicBox.java test has no control buttons
  • 3df08b2: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • 04aa5f8: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 20ee52e: 8331063: Some HttpClient tests don't report leaks
  • c2dd771: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
  • d41ad82: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 544ab78: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
  • 4621d59: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 978b793: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/0fc9b025f4fe0dabfd889d28d51f5e3218d21fde...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3ebf8c9359da2f45e4cefb7be2276d33c30979aa 8329663: hs_err file event log entry for thread adding/removing should print current thread Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 21, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit e2de2b9.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 879e803: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10
  • c73a074: 8321220: JFR: RecordedClass reports incorrect modifiers
  • 70b623f: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
  • 251b8e1: 8334333: MissingResourceCauseTestRun.java fails if run by root
  • 4397fe8: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 789cb95: 8316306: Open source and convert manual Swing test
  • 953a03d: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
  • 02ec672: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 0392d4e: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • f9cc9e9: 8334332: TestIOException.java fails if run by root
  • ... and 23 more: https://git.openjdk.org/jdk17u-dev/compare/0fc9b025f4fe0dabfd889d28d51f5e3218d21fde...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@MBaesken Pushed as commit e2de2b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants