Skip to content

Conversation

@elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Jun 19, 2024

Clean backport to Make runtime/Thread/ThreadCountLimit.java more robust.
GHA tested


Progress

  • Change must not contain extraneous whitespace
  • JDK-8293872 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8293872: Make runtime/Thread/ThreadCountLimit.java more robust (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2614/head:pull/2614
$ git checkout pull/2614

Update a local copy of the PR:
$ git checkout pull/2614
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2614

View PR using the GUI difftool:
$ git pr show -t 2614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2614.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293872: Make runtime/Thread/ThreadCountLimit.java more robust

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • c2dd771: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
  • d41ad82: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 544ab78: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
  • 4621d59: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 978b793: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • 8751ace: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 5fc41c8: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 5c3fc1d: 8334335: [TESTBUG] Backport of 8279164 to 11u & 17u includes elements of JDK-8163327
  • ed56f5b: 8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
  • d056b73: 8325621: Improve jspawnhelper version checks
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/4976dc83bbcc1275d16f0beff287c920c929f96c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 36b61c5d7e7732924f494fa24c0e286e41279fc3 8293872: Make runtime/Thread/ThreadCountLimit.java more robust Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2024

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval JDK-8293872 request.Clean backport to Make runtime/Thread/ThreadCountLimit.java more robust.
GHA tested

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@elifaslan1
JDK-8293872: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 19, 2024
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@elifaslan1
Your change (at version 53ad4d4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

Going to push as commit 33dbf71.
Since your change was applied there have been 17 commits pushed to the master branch:

  • e996135: 8320079: The ArabicBox.java test has no control buttons
  • 3df08b2: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • 04aa5f8: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 20ee52e: 8331063: Some HttpClient tests don't report leaks
  • c2dd771: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
  • d41ad82: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 544ab78: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
  • 4621d59: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 978b793: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • 8751ace: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/4976dc83bbcc1275d16f0beff287c920c929f96c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2024
@openjdk openjdk bot closed this Jun 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@phohensee @elifaslan1 Pushed as commit 33dbf71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@elifaslan1 elifaslan1 deleted the JDK-8293872 branch September 25, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants