-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334441: Mark tests in jdk_security_infra group as manual #2627
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
The GHA test runner report a failure, it's unrelated to this PR.
|
/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk. |
@sendaoYan |
Please close. It's in jdk17u. |
Okey. |
Hi all,
This pull request contains a backport of commit 8e1d2b09 from the openjdk/jdk repository.
The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was reviewed by Christoph Langer and Sean Mullan.
The file
test/jdk/TEST.groups
has a prefixed PR JDK-8257516 cause this backport not clean, andjdk17u-dev
repo doesn't have filetest/jdk/security/infra/javax/net/ssl/HttpsURLConnectionTest.java
, other files are backported cleanly.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2627/head:pull/2627
$ git checkout pull/2627
Update a local copy of the PR:
$ git checkout pull/2627
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2627/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2627
View PR using the GUI difftool:
$ git pr show -t 2627
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2627.diff
Webrev
Link to Webrev Comment