Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277087: ZipException: zip END header not found at ZipFile#Source.findEND #263

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 18, 2022

I think this is a useful backport of a bugfix for 17u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277087: ZipException: zip END header not found at ZipFile#Source.findEND

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/263.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e3243ee963d074c892a0ed16a00fd91b440c96ac 8277087: ZipException: zip END header not found at ZipFile#Source.findEND Mar 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277087: ZipException: zip END header not found at ZipFile#Source.findEND

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 18, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2022

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 19, 2022

Pre-submit test:gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 I have seen this before in other tests. Unrelated

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 20, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 20, 2022

Going to push as commit a605a30.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cbe4973: 8278851: Correct signer logic for jars signed with multiple digestalgs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 20, 2022
@openjdk openjdk bot closed this Mar 20, 2022
@openjdk openjdk bot removed ready rfr labels Mar 20, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 20, 2022

@GoeLin Pushed as commit a605a30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant