-
Notifications
You must be signed in to change notification settings - Fork 231
8051959: Add thread and timestamp options to java.security.debug system property #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Should get backported for parity with 17.0.13-oracle. The backport has been reviewed and tier 1-4 have passed. |
|
@TheRealMDoerr |
|
/integrate |
|
Going to push as commit f277b39.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit f277b39. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8051959. Version from 21u applies cleanly, but requires a small adaptation:
1st commit: Same as openjdk/jdk21u-dev#761
2nd commit: Replace currentThread().threadId() by currentThread().getId() because Loom is not in 17u.
Included test has passed.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2631/head:pull/2631$ git checkout pull/2631Update a local copy of the PR:
$ git checkout pull/2631$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2631/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2631View PR using the GUI difftool:
$ git pr show -t 2631Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2631.diff
Webrev
Link to Webrev Comment