8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections

[MBaesken]

Backport of 8329605; we use NULL instead of nullptr in 17 and minor adjustment in nmethod.cpp .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329605 needs maintainer approval

Issue

• JDK-8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections (Enhancement - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2636/head:pull/2636
$ git checkout pull/2636

Update a local copy of the PR:
$ git checkout pull/2636
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2636

View PR using the GUI difftool:
$ git pr show -t 2636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2636.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 859dda1: 8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml
• a963e2d: 8241550: [macOS] SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use"
• 0c0871d: 8316389: Open source few AWT applet tests
• 35cac7f: 8301704: Shorten the number of GCs in UnloadingTest.java to verify a class loader not being unloaded
• b09c9eb: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
• c281c1c: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
• 1fe0bb4: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
• c858b68: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
• 8f5a9f7: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
• ba3db30: 8319197: Exclude hb-subset and hb-style from compilation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (5608b234)

[TheRealMDoerr]

Can you use nullptr in the new code, please? That will help to reduce conflicts with further backports. Otherwise, LGTM.

[MBaesken]

Can you use nullptr in the new code, please? That will help to reduce conflicts with further backports. Otherwise, LGTM.

That would give use quite a bad mixture of NULL and nullptr in some places, is that what we want?

[TheRealMDoerr]

Ok, I leave you free to decide about usage of NULL vs. nullptr. We may want to change to nullptr at some point of time in order to make backporting easier. LGTM.

[openjdk]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[MBaesken]

/integrate

[openjdk]

Going to push as commit b99923c.
Since your change was applied there have been 10 commits pushed to the master branch:

• 859dda1: 8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml
• a963e2d: 8241550: [macOS] SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use"
• 0c0871d: 8316389: Open source few AWT applet tests
• 35cac7f: 8301704: Shorten the number of GCs in UnloadingTest.java to verify a class loader not being unloaded
• b09c9eb: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
• c281c1c: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
• 1fe0bb4: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
• c858b68: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
• 8f5a9f7: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
• ba3db30: 8319197: Exclude hb-subset and hb-style from compilation

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit b99923c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.