8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping

[pengxiaolong]

Hi all,

This pull request contains a backport of commit 4c79e7d5 from the openjdk/jdk repository.

The commit being backported was authored by Ivan Walulya on 12 Oct 2023 and was reviewed by Thomas Schatzl and Albert Mingkun Yang.

Additional test:

• make test TEST=test/hotspot/jtreg/:tier2 CONF=linux-aarch64-server-fastdebug
  There were two irrelevant failures, I have created bug for them https://bugs.openjdk.org/browse/JDK-8335127

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8170817 needs maintainer approval

Issue

• JDK-8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping (Enhancement - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2639/head:pull/2639
$ git checkout pull/2639

Update a local copy of the PR:
$ git checkout pull/2639
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2639

View PR using the GUI difftool:
$ git pr show -t 2639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2639.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pengxiaolong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• acff32c: 8328896: Fontmetrics for large Fonts has zero width
• 445aba4: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• 5b43be2: 8317372: Refactor some NumberFormat tests to use JUnit
• 719f9ce: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• 2b128f1: 8222884: ConcurrentClassDescLookup.java times out intermittently
• dae2d6c: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
• b903b50: Merge
• c1c9011: 8334441: Mark tests in jdk_security_infra group as manual
• 11f5d00: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• f277b39: 8051959: Add thread and timestamp options to java.security.debug system property
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/a963e2d713b58c74e4778dea111a014445c5c926...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a12acceb)

[pengxiaolong]

/approval request Backport JDK-8170817 to jdk17; not clean due to the well known NULL -> nullptr change; risk is low, the fix has been in tip for over 8 months, also ran tier1 and tier2 test.

[openjdk]

@pengxiaolong
8170817: The approval request has been created successfully.

[pengxiaolong]

/approval cancel applied too early

[openjdk]

@pengxiaolong
8170817: The approval request has been cancelled successfully.

[phohensee]

nullptr -> NULL. Lgtm.

[openjdk]

⚠️ @pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[pengxiaolong]

Thank you Paul!

[pengxiaolong]

/approval request Backport JDK-8170817 to jdk17; not clean due to the well known NULL -> nullptr change, reviewed by @phohensee; risk is low, the fix has been in tip for over 8 months, also ran tier1 and tier2 test.

[openjdk]

@pengxiaolong
8170817: The approval request has been created successfully.

[pengxiaolong]

Thanks for the review and approval!

/integrate

[openjdk]

@pengxiaolong
Your change (at version a12acce) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 1070100.
Since your change was applied there have been 12 commits pushed to the master branch:

• acff32c: 8328896: Fontmetrics for large Fonts has zero width
• 445aba4: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• 5b43be2: 8317372: Refactor some NumberFormat tests to use JUnit
• 719f9ce: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• 2b128f1: 8222884: ConcurrentClassDescLookup.java times out intermittently
• dae2d6c: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
• b903b50: Merge
• c1c9011: 8334441: Mark tests in jdk_security_infra group as manual
• 11f5d00: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• f277b39: 8051959: Add thread and timestamp options to java.security.debug system property
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/a963e2d713b58c74e4778dea111a014445c5c926...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @pengxiaolong Pushed as commit 1070100.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.