Skip to content

8328896: Fontmetrics for large Fonts has zero width #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 26, 2024

Clean backport of JDK-8328896.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328896 needs maintainer approval

Issue

  • JDK-8328896: Fontmetrics for large Fonts has zero width (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2640/head:pull/2640
$ git checkout pull/2640

Update a local copy of the PR:
$ git checkout pull/2640
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2640

View PR using the GUI difftool:
$ git pr show -t 2640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2640.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328896: Fontmetrics for large Fonts has zero width

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 445aba4: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • 5b43be2: 8317372: Refactor some NumberFormat tests to use JUnit
  • 719f9ce: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
  • 2b128f1: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • dae2d6c: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • b903b50: Merge
  • c1c9011: 8334441: Mark tests in jdk_security_infra group as manual
  • 11f5d00: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • f277b39: 8051959: Add thread and timestamp options to java.security.debug system property
  • b99923c: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a963e2d713b58c74e4778dea111a014445c5c926...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 25871af36b1397bdc3715ab0edc589f0483ea0b1 8328896: Fontmetrics for large Fonts has zero width Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 17.0.13-oracle. Applies cleanly and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@TheRealMDoerr
8328896: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 27, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

Going to push as commit acff32c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 445aba4: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • 5b43be2: 8317372: Refactor some NumberFormat tests to use JUnit
  • 719f9ce: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
  • 2b128f1: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • dae2d6c: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • b903b50: Merge
  • c1c9011: 8334441: Mark tests in jdk_security_infra group as manual
  • 11f5d00: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • f277b39: 8051959: Add thread and timestamp options to java.security.debug system property
  • b99923c: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a963e2d713b58c74e4778dea111a014445c5c926...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2024
@openjdk openjdk bot closed this Jun 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@TheRealMDoerr Pushed as commit acff32c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant