Skip to content

8334653: ISO 4217 Amendment 177 Update #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8334653: ISO 4217 Amendment 177 Update #2645

wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 28, 2024 •
edited by openjdk bot
Loading

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334653 needs maintainer approval

Issue

  • JDK-8334653: ISO 4217 Amendment 177 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2645/head:pull/2645
$ git checkout pull/2645

Update a local copy of the PR:
$ git checkout pull/2645
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2645

View PR using the GUI difftool:
$ git pr show -t 2645

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2645.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024 •
edited
Loading

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334653: ISO 4217 Amendment 177 Update

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 5e3825a: 8307850: update for deprecated sprintf for jdk.jdi
  • b151753: 8299396: Remove metaprogramming/removeExtent.hpp
  • 368181e: 8335808: update for deprecated sprintf for jfrTypeSetUtils
  • 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
  • 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
  • 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
  • 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
  • f019a81: 8303830: update for deprecated sprintf for jdk.accessibility
  • ef24cdf: 8307848: update for deprecated sprintf for jdk.attach
  • ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/acff32c3ea372eb0a25edd92f8944d733802d2d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 86b0cf259fb3cbe3a1973151148e5d36c6a99d91 8334653: ISO 4217 Amendment 177 Update Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024 •
edited
Loading

Webrevs

TheRealMDoerr
TheRealMDoerr approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's not clean because of JDK-8257733. LGTM. Do you know why the GHA tests have failed?

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Update ValidateISO4217.java - adjust line 64
62319ba 
error was like this
/home/runner/work/jdk17u-dev/jdk17u-dev/test/jdk/java/util/Currency/ValidateISO4217.java:64: error: unmappable character (0xE2) for encoding US-ASCII
 * \ufffd\ufffd\ufffdList one: Currency, fund and precious metal codes\ufffd\ufffd\ufffd has the following
TheRealMDoerr
TheRealMDoerr approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this should fix the GHA test problems. Thanks!

@openjdk openjdk bot added the approval label Jul 1, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 8, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

Going to push as commit 42f9791.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 5e3825a: 8307850: update for deprecated sprintf for jdk.jdi
  • b151753: 8299396: Remove metaprogramming/removeExtent.hpp
  • 368181e: 8335808: update for deprecated sprintf for jfrTypeSetUtils
  • 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
  • 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
  • 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
  • 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
  • f019a81: 8303830: update for deprecated sprintf for jdk.accessibility
  • ef24cdf: 8307848: update for deprecated sprintf for jdk.attach
  • ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/acff32c3ea372eb0a25edd92f8944d733802d2d0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2024
@openjdk openjdk bot closed this Jul 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@MBaesken Pushed as commit 42f9791.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealMDoerr TheRealMDoerr TheRealMDoerr approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBaesken @TheRealMDoerr