8335536: Fix assertion failure in IdealGraphPrinter when append is true

[MaxXSoft]

Hi all,

This pull request contains a backport of commit 6db4c6a7 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein.

The original patch does not apply cleanly to 17u due to some merge conflicts about creating xmlStream with placement new expressions.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8335536 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8335536: Fix assertion failure in IdealGraphPrinter when append is true (Bug - P5 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2657/head:pull/2657
$ git checkout pull/2657

Update a local copy of the PR:
$ git checkout pull/2657
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2657

View PR using the GUI difftool:
$ git pr show -t 2657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2657.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back qxing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MaxXSoft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335536: Fix assertion failure in IdealGraphPrinter when append is true

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• 7f8fdbd: 8335967: "text-decoration: none" does not work with "A" HTML tags
• 9ca6608: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978
• 8f32625: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
• 4d03e9d: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• a76c3af: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
• 8bb51e5: 8317635: Improve GetClassFields test to verify correctness of field order
• 1000028: 8292044: HttpClient doesn't handle 102 or 103 properly
• 2ec8717: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
• ... and 121 more: https://git.openjdk.org/jdk17u-dev/compare/379a14bb49f9445d384c9fa5f8e4804804a7ee22...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (6a4a350d)

[bridgekeeper]

@MaxXSoft This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[MaxXSoft]

Hi all,

This backport fixes some assertion failures in IdealGraphPrinter when debugging on ideal graph, which is low risk.

Could someone please review this PR?

Thanks!

[phohensee]

Please configure pre-submit testing on this repo.

[openjdk]

⚠️ @MaxXSoft This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[MaxXSoft]

@phohensee Thanks for the review! I have enabled testing in my repository.

[MaxXSoft]

/approval request Backporting this patch fixes assertion failures when debugging on ideal graph. Risk is low. The original patch does not apply cleanly to 17u due to some merge conflicts about creating xmlStream with placement new expressions.

[openjdk]

@MaxXSoft
8335536: The approval request has been created successfully.

[MaxXSoft]

/integrate

[openjdk]

@MaxXSoft
Your change (at version 6a4a350) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

Presubmit testing for macos seems to be hung.

[openjdk]

Going to push as commit ae7be19.
Since your change was applied there have been 132 commits pushed to the master branch:

• 1f14f86: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
• 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• 7f8fdbd: 8335967: "text-decoration: none" does not work with "A" HTML tags
• 9ca6608: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978
• 8f32625: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
• 4d03e9d: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• a76c3af: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
• 8bb51e5: 8317635: Improve GetClassFields test to verify correctness of field order
• 1000028: 8292044: HttpClient doesn't handle 102 or 103 properly
• ... and 122 more: https://git.openjdk.org/jdk17u-dev/compare/379a14bb49f9445d384c9fa5f8e4804804a7ee22...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @MaxXSoft Pushed as commit ae7be19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.