Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282444: Module finder incorrectly assumes default file system path-separator character #266

Conversation

ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Mar 21, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282444: Module finder incorrectly assumes default file system path-separator character

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/266/head:pull/266
$ git checkout pull/266

Update a local copy of the PR:
$ git checkout pull/266
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 266

View PR using the GUI difftool:
$ git pr show -t 266

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/266.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2022

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 369291b265e13d625c5f465da9b1854c0d70c435 8282444: Module finder incorrectly assumes default file system path-separator character Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 21, 2022
@ChrisHegarty
Copy link
Member Author

/clean

@openjdk openjdk bot added the clean label Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@ChrisHegarty This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@ChrisHegarty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282444: Module finder incorrectly assumes default file system path-separator character

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2022

Webrevs

@ChrisHegarty
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit 3c123f3.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 13140f9: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly
  • 1705541: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
  • d62a116: Merge
  • c3ea7ca: 8282761: XPathFactoryImpl remove setProperty and getProperty methods
  • 18ece9b: 8282345: handle latest VS2022 in abstract_vm_version
  • d442446: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info
  • d6eb281: 8280543: Update the "java" and "jcmd" tool specification for CDS
  • d19ec6f: 8193682: Infinite loop in ZipOutputStream.close()
  • 937b55c: 8282583: Update BCEL md to include the copyright notice
  • a7efcca: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/049b1baaf5d8535a59b5e2d96317560f2c83ae41...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@ChrisHegarty Pushed as commit 3c123f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant