Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296812: sprintf is deprecated in Xcode 14 #2662

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 4, 2024

Applies cleanly other than src/hotspot/share/jfr/support/jfrSymbolTable.cpp being missing in jdk17u-dev


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8296812 needs maintainer approval

Issue

  • JDK-8296812: sprintf is deprecated in Xcode 14 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2662/head:pull/2662
$ git checkout pull/2662

Update a local copy of the PR:
$ git checkout pull/2662
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2662

View PR using the GUI difftool:
$ git pr show -t 2662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2662.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296812: sprintf is deprecated in Xcode 14

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c025eb6: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 478ef389dc3767edfbe21d10a7f7f1522c648c2e 8296812: sprintf is deprecated in Xcode 14 Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Jul 4, 2024

GHA failure on Linux x64 of java/lang/ProcessBuilder/PipelineLeaksFD seems to be covered by #2615 (test issue).

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/hotspot/share/jfr/support/jfrSymbolTable.cpp got added with https://bugs.openjdk.org/browse/JDK-8266936 which is only in JDK 18+. This looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gdams
Copy link
Member Author

gdams commented Jul 4, 2024

/approval request This change applies cleanly other than the lack of one file. All tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@gdams
8296812: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Jul 4, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 5, 2024
@gdams
Copy link
Member Author

gdams commented Jul 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

Going to push as commit 123b973.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c0869db: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • c025eb6: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2024
@openjdk openjdk bot closed this Jul 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@gdams Pushed as commit 123b973.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the sprintf_xcode branch July 5, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants