-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296812: sprintf is deprecated in Xcode 14 #2662
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
GHA failure on Linux x64 of java/lang/ProcessBuilder/PipelineLeaksFD seems to be covered by #2615 (test issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/hotspot/share/jfr/support/jfrSymbolTable.cpp
got added with https://bugs.openjdk.org/browse/JDK-8266936 which is only in JDK 18+. This looks good to me.
|
/approval request This change applies cleanly other than the lack of one file. All tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs. |
/integrate |
Going to push as commit 123b973.
Your commit was automatically rebased without conflicts. |
Applies cleanly other than
src/hotspot/share/jfr/support/jfrSymbolTable.cpp
being missing in jdk17u-devProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2662/head:pull/2662
$ git checkout pull/2662
Update a local copy of the PR:
$ git checkout pull/2662
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2662/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2662
View PR using the GUI difftool:
$ git pr show -t 2662
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2662.diff
Webrev
Link to Webrev Comment