8299395: Remove metaprogramming/removeCV.hpp

[gdams]

prerequisite to bumping googletest to 1.13.0

Applies cleanly other than the deleted file (src/hotspot/share/metaprogramming/removeCV.hpp) having some extra commits.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8299395 needs maintainer approval

Issue

• JDK-8299395: Remove metaprogramming/removeCV.hpp (Enhancement - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2673/head:pull/2673
$ git checkout pull/2673

Update a local copy of the PR:
$ git checkout pull/2673
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2673

View PR using the GUI difftool:
$ git pr show -t 2673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2673.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299395: Remove metaprogramming/removeCV.hpp

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 9016d2c: 8300169: Build failure with clang-15
• 42f9791: 8334653: ISO 4217 Amendment 177 Update
• 5e3825a: 8307850: update for deprecated sprintf for jdk.jdi
• b151753: 8299396: Remove metaprogramming/removeExtent.hpp
• 368181e: 8335808: update for deprecated sprintf for jfrTypeSetUtils
• 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
• e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
• 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
• ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/f87aa3013ae926a079bde0ba88157e7590ac4a56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e5a4800b)

[openjdk]

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gdams]

/approval request Applies cleanly other than the deleted file (src/hotspot/share/metaprogramming/removeCV.hpp containing some extra commits, Low risk, required as part of the macOS/Xcode upgrade

[openjdk]

@gdams
8299395: The approval request has been created successfully.

[gdams]

/integrate

[openjdk]

Going to push as commit 131c043.
Since your change was applied there have been 27 commits pushed to the master branch:

• 9016d2c: 8300169: Build failure with clang-15
• 42f9791: 8334653: ISO 4217 Amendment 177 Update
• 5e3825a: 8307850: update for deprecated sprintf for jdk.jdi
• b151753: 8299396: Remove metaprogramming/removeExtent.hpp
• 368181e: 8335808: update for deprecated sprintf for jfrTypeSetUtils
• 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
• e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
• 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
• ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/f87aa3013ae926a079bde0ba88157e7590ac4a56...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gdams Pushed as commit 131c043.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.