-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299481: Remove metaprogramming/removePointer.hpp #2674
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/approval request Applies cleanly other than the deleted file (src/hotspot/share/metaprogramming/removePointer.hpp) containing some extra commits, Low risk, required as part of the macOS/Xcode upgrade |
/integrate |
Going to push as commit e79c42e. |
prerequisite to bumping googletest to 1.13.0
Applies cleanly other than the deleted file (
src/hotspot/share/metaprogramming/removePointer.hpp
) containing some extra commitsProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2674/head:pull/2674
$ git checkout pull/2674
Update a local copy of the PR:
$ git checkout pull/2674
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2674/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2674
View PR using the GUI difftool:
$ git pr show -t 2674
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2674.diff
Webrev
Link to Webrev Comment