Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299481: Remove metaprogramming/removePointer.hpp #2674

Closed
wants to merge 3 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 5, 2024

prerequisite to bumping googletest to 1.13.0

Applies cleanly other than the deleted file (src/hotspot/share/metaprogramming/removePointer.hpp) containing some extra commits


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299481 needs maintainer approval

Issue

  • JDK-8299481: Remove metaprogramming/removePointer.hpp (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2674/head:pull/2674
$ git checkout pull/2674

Update a local copy of the PR:
$ git checkout pull/2674
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2674

View PR using the GUI difftool:
$ git pr show -t 2674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2674.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into pr/2673 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299481: Remove metaprogramming/removePointer.hpp

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d53cac379419b7b74df045bb119df6d5f9e91878 8299481: Remove metaprogramming/removePointer.hpp Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2024

Webrevs

@gdams
Copy link
Member Author

gdams commented Jul 8, 2024

/approval request Applies cleanly other than the deleted file (src/hotspot/share/metaprogramming/removePointer.hpp) containing some extra commits, Low risk, required as part of the macOS/Xcode upgrade

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@gdams
8299481: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jul 8, 2024
@gdams gdams changed the base branch from pr/2673 to master July 8, 2024 15:21
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2024
@gdams
Copy link
Member Author

gdams commented Jul 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

Going to push as commit e79c42e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2024
@openjdk openjdk bot closed this Jul 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@gdams Pushed as commit e79c42e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants