Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland #2677

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 5, 2024

Backport of 8280993


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280993 needs maintainer approval

Issues

  • JDK-8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland (Bug - P3 - Approved)
  • JDK-8307529: [XWayland] Popup is not closed on click outside of area controlled by XWayland (CSR) (Withdrawn)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2677/head:pull/2677
$ git checkout pull/2677

Update a local copy of the PR:
$ git checkout pull/2677
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2677/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2677

View PR using the GUI difftool:
$ git pr show -t 2677

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2677.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
  • 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
  • 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
  • f019a81: 8303830: update for deprecated sprintf for jdk.accessibility
  • ef24cdf: 8307848: update for deprecated sprintf for jdk.attach
  • b1cb211: 8308022: update for deprecated sprintf for java.base
  • a59e873: 8303527: update for deprecated sprintf for jdk.hotspot.agent
  • aa868bb: 8301132: Test update for deprecated sprintf in Xcode 14
  • 10fb011: 8302495: update for deprecated sprintf for java.desktop
  • cc44d7d: 8301274: update for deprecated sprintf for security components
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/f87aa3013ae926a079bde0ba88157e7590ac4a56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3d550f748521443dc2e148aa4f786060419f1113 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2024

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Jul 5, 2024

mostly clean but a bit manual work needed in UNIXToolkit.java in the imports

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please wait for the tests to complete successfully.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 8, 2024

windows-aarch64 : fixpath has a segfault, most likely unrelated.
macos : unusable test results, I do not get even a build log to analyze something; no issues seen in our test infrastructure so most likely unrelated too

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 8, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

Going to push as commit 0485f4c.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2024
@openjdk openjdk bot closed this Jul 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@MBaesken Pushed as commit 0485f4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants