Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301132: Test update for deprecated sprintf in Xcode 14 #2679

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 6, 2024

Backport applies cleanly, required to upgrade the GH actions runners to macos-13/Xcode 14


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301132 needs maintainer approval

Issue

  • JDK-8301132: Test update for deprecated sprintf in Xcode 14 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2679/head:pull/2679
$ git checkout pull/2679

Update a local copy of the PR:
$ git checkout pull/2679
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2679

View PR using the GUI difftool:
$ git pr show -t 2679

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2679.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301132: Test update for deprecated sprintf in Xcode 14

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9c4bc2c3954b97821a2bf371cab61edbc3d81d36 8301132: Test update for deprecated sprintf in Xcode 14 Jul 6, 2024
@openjdk
Copy link

openjdk bot commented Jul 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2024

Webrevs

@gdams
Copy link
Member Author

gdams commented Jul 6, 2024

/approval request This backport applies cleanly. All tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

@gdams
8301132: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 6, 2024
@gdams
Copy link
Member Author

gdams commented Jul 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

Going to push as commit aa868bb.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 10fb011: 8302495: update for deprecated sprintf for java.desktop

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 6, 2024
@openjdk openjdk bot closed this Jul 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2024
@openjdk
Copy link

openjdk bot commented Jul 6, 2024

@gdams Pushed as commit aa868bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant