-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335808: update for deprecated sprintf for jfrTypeSetUtils #2688
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/approval request Low risk, all tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs. |
/integrate |
Going to push as commit 368181e.
Your commit was automatically rebased without conflicts. |
The occurrence of
sprintf
was removed in JDK18 as part of https://bugs.openjdk.org/browse/JDK-8266936. This patch simply converts it tosnprintf
to avoid build failures.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2688/head:pull/2688
$ git checkout pull/2688
Update a local copy of the PR:
$ git checkout pull/2688
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2688/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2688
View PR using the GUI difftool:
$ git pr show -t 2688
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2688.diff
Webrev
Link to Webrev Comment