Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335808: update for deprecated sprintf for jfrTypeSetUtils #2688

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 6, 2024

The occurrence of sprintf was removed in JDK18 as part of https://bugs.openjdk.org/browse/JDK-8266936. This patch simply converts it to snprintf to avoid build failures.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335808 needs maintainer approval

Issue

  • JDK-8335808: update for deprecated sprintf for jfrTypeSetUtils (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2688/head:pull/2688
$ git checkout pull/2688

Update a local copy of the PR:
$ git checkout pull/2688
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2688

View PR using the GUI difftool:
$ git pr show -t 2688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2688.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2024

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335808: update for deprecated sprintf for jfrTypeSetUtils

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
  • 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
  • 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
  • 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
  • f019a81: 8303830: update for deprecated sprintf for jdk.accessibility
  • ef24cdf: 8307848: update for deprecated sprintf for jdk.attach
  • b1cb211: 8308022: update for deprecated sprintf for java.base
  • a59e873: 8303527: update for deprecated sprintf for jdk.hotspot.agent
  • aa868bb: 8301132: Test update for deprecated sprintf in Xcode 14
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/cc44d7d24e17a97e9dc05c574d508ae6f9f71505...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2024

Webrevs

@openjdk openjdk bot mentioned this pull request Jul 6, 2024
4 tasks
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gdams
Copy link
Member Author

gdams commented Jul 8, 2024

/approval request Low risk, all tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@gdams
8335808: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 8, 2024
@gdams
Copy link
Member Author

gdams commented Jul 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

Going to push as commit 368181e.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 582bd63: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • e96daf3: 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests
  • 0e72952: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
  • 7d7c0f5: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
  • 6d2c7a7: 8308801: update for deprecated sprintf for libnet in java.base
  • f019a81: 8303830: update for deprecated sprintf for jdk.accessibility
  • ef24cdf: 8307848: update for deprecated sprintf for jdk.attach
  • b1cb211: 8308022: update for deprecated sprintf for java.base
  • a59e873: 8303527: update for deprecated sprintf for jdk.hotspot.agent
  • aa868bb: 8301132: Test update for deprecated sprintf in Xcode 14
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/cc44d7d24e17a97e9dc05c574d508ae6f9f71505...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2024
@openjdk openjdk bot closed this Jul 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@gdams Pushed as commit 368181e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the jfrTypeSetUtils branch July 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants