8300260: Remove metaprogramming/isSame.hpp

[gdams]

Applies cleanly other than src/hotspot/share/utilities/devirtualizer.inline.hpp being called src/hotspot/share/memory/iterator.inline.hpp in 17u-dev due to us not backporting openjdk/jdk@9f8bfab

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8300260 needs maintainer approval

Issue

• JDK-8300260: Remove metaprogramming/isSame.hpp (Enhancement - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer) ⚠️ Review applies to 81cff824

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2692/head:pull/2692
$ git checkout pull/2692

Update a local copy of the PR:
$ git checkout pull/2692
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2692

View PR using the GUI difftool:
$ git pr show -t 2692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2692.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into pr/2691 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300260: Remove metaprogramming/isSame.hpp

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 3069e3e: 8305959: x86: Improve itable_stub
• e43402d: 8335918: update for deprecated sprintf for jvmti

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full (db6bfcb8)
• 02: Full - Incremental (81cff824)
• 01: Full - Incremental (40816b54)
• 00: Full (3123777b)

[gdams]

/approval request this backport applies cleanly other than one file having a different name due to a jdk20+ patch not existing in 17u

[openjdk]

@gdams
8300260: The approval request has been created successfully.

[openjdk]

⚠️ @gdams This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[jerboaa]

GHA build failures are due to google mock warnings being treated as errors. Should be fixed with #2667

[gdams]

/integrate

[openjdk]

Going to push as commit f9acc53.
Since your change was applied there have been 2 commits pushed to the master branch:

• 3069e3e: 8305959: x86: Improve itable_stub
• e43402d: 8335918: update for deprecated sprintf for jvmti

Your commit was automatically rebased without conflicts.

[openjdk]

@gdams Pushed as commit f9acc53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.