8300910: Remove metaprogramming/integralConstant.hpp#2694
8300910: Remove metaprogramming/integralConstant.hpp#2694gdams wants to merge 15 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
|
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/approval request This backport applies cleanly. All tests pass. This is also crucial to allow us to upgrade the GH actions workflow to move away from the deprecated macos-11 VMs. |
|
|
|
/integrate |
|
@gdams Unknown command |
|
/integrate |
1 similar comment
|
/integrate |
|
Going to push as commit e809008. |
|
@gdams The command |
Applies cleanly. Prerequisite to bumping gtest which indirectly fixes xcode14 builds
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2694/head:pull/2694$ git checkout pull/2694Update a local copy of the PR:
$ git checkout pull/2694$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2694/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2694View PR using the GUI difftool:
$ git pr show -t 2694Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2694.diff
Webrev
Link to Webrev Comment