-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325194: GHA: Add macOS M1 testing #2697
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
/issue add 8325444 |
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@gdams |
/issue add 8309934 |
@gdams |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout macos14
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@gdams this pull request can not be integrated into git checkout macos14
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
/approval request backport applies cleanly (except for obvious boot JDK URL changes), affects CI only |
/integrate |
Going to push as commit cfe714b.
Your commit was automatically rebased without conflicts. |
Now that macOS M1 executors are available in GitHub actions it makes sense to move the build to run on M1 (rather than cross-compiled) and also enable testing on the platform.
Applies cleanly other than the following:
.github/actions/get-jtreg/action.yml
I also integrated openjdk/jdk@3c91b59 as it caused a regression in tipmake/conf/github-actions.conf
having the obvious difference in version numbers for the boot JDK (I also took the liberty of reordering them to be consistent with tip)Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2697/head:pull/2697
$ git checkout pull/2697
Update a local copy of the PR:
$ git checkout pull/2697
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2697/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2697
View PR using the GUI difftool:
$ git pr show -t 2697
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2697.diff
Webrev
Link to Webrev Comment