8329109: Threads::print_on() tries to print CPU time for terminated GC threads

[MBaesken]

Backport of 8329109

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329109 needs maintainer approval

Issue

• JDK-8329109: Threads::print_on() tries to print CPU time for terminated GC threads (Bug - P3 - Approved)

Reviewers

• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2698/head:pull/2698
$ git checkout pull/2698

Update a local copy of the PR:
$ git checkout pull/2698
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2698

View PR using the GUI difftool:
$ git pr show -t 2698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2698.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329109: Threads::print_on() tries to print CPU time for terminated GC threads

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e809008: 8300910: Remove metaprogramming/integralConstant.hpp
• 952d272: 8300265: Remove metaprogramming/isSigned.hpp
• f9acc53: 8300260: Remove metaprogramming/isSame.hpp
• 3069e3e: 8305959: x86: Improve itable_stub

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[MBaesken]

jdk17 has a little diff in the Threads::print_on method - StringDedup::threads_do(&cl); is present there, those threads are JavaThreads in 21+ but not in lower releases (see 8305566: Change StringDedup thread to derive from JavaThread).

[mlbridge]

Webrevs

• 00: Full (3b519ee1)

[reinrich]

Looks good.
Thanks, Richard.

[MBaesken]

macos has currently GHA issues, those are unrelated and worked on in separate PRs.

[openjdk]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 3d83f3e.
Since your change was applied there have been 5 commits pushed to the master branch:

• 1e63af9: 8300806: Update googletest to v1.13.0
• e809008: 8300910: Remove metaprogramming/integralConstant.hpp
• 952d272: 8300265: Remove metaprogramming/isSigned.hpp
• f9acc53: 8300260: Remove metaprogramming/isSame.hpp
• 3069e3e: 8305959: x86: Improve itable_stub

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 3d83f3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.